Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Segment Replication] Handle update target cp for relocating primary #6757

Merged
merged 1 commit into from
Mar 20, 2023
Merged

[Segment Replication] Handle update target cp for relocating primary #6757

merged 1 commit into from
Mar 20, 2023

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Mar 20, 2023 •
edited
Loading

Description

As part of #6563, primary tracks the target replication checkpoint of target while responding get_segment_files call. But, during primary relocation this breaks as primary is not in active primary mode and fails assertPrimaryMode() assertion leading to test failures. During primary handoff, the target shard is activated with primary context.

Primary shard routing before and after relocation is started.

[2023-03-20T14:19:20,164][INFO ][o.o.i.r.SegmentReplicationSourceService] [node_t7] --> oldRouting [test][44], node[FIVJG3pnRaa-irH_1SjJkg], [P], s[STARTED], a[id=o8B_jOT1QO-XF4JmOSGZLw]
[2023-03-20T14:19:20,164][INFO ][o.o.i.r.SegmentReplicationSourceService] [node_t7] --> newRouting [test][44], node[FIVJG3pnRaa-irH_1SjJkg], relocating [YhTm5x0BSe63RPmK4Wg0fg], [P], s[RELOCATING], a[id=o8B_jOT1QO-XF4JmOSGZLw, rId=ysSq8jpVQWK5HUL1Osbb3Q], expected_shard_size[230]

Issues Resolved

#6740

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89
[Segment Replication] Handle update target cp for relocating primary
d6cc558 
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89 dreamer-89 merged commit 7628de8 into opensearch-project:main Mar 20, 2023
@dreamer-89 dreamer-89 added the backport 2.x Backport to 2.x branch label Mar 20, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 20, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2023
@github-actions
[Segment Replication] Handle update target cp for relocating primary (#…
85f3940 
…6757)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit 7628de8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89 pushed a commit that referenced this pull request Mar 20, 2023
@opensearch-trigger-bot @github-actions
[Segment Replication] Handle update target cp for relocating primary (#…
bbd2785 
…6757) (#6759)

(cherry picked from commit 7628de8)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dreamer-89 dreamer-89 mentioned this pull request Mar 20, 2023
Closed
mingshl pushed a commit to mingshl/OpenSearch-Mingshl that referenced this pull request Mar 24, 2023
@dreamer-89 @mingshl
[Segment Replication] Handle update target cp for relocating primary (o…
04f9c2f 
…pensearch-project#6757)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
mitrofmep pushed a commit to mitrofmep/OpenSearch that referenced this pull request Apr 5, 2023
@dreamer-89 @mitrofmep
[Segment Replication] Handle update target cp for relocating primary (o…
2ba641a 
…pensearch-project#6757)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Valentin Mitrofanov <mitrofmep@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mch2 mch2 mch2 approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@xuezhou25 xuezhou25 Awaiting requested review from xuezhou25

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dreamer-89 @mch2